Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add prediction container URI builder method #805
feat: Add prediction container URI builder method #805
Changes from 3 commits
b104d63
b234f78
728208e
dc5647a
dde6834
d34ba3d
9c8742a
2694705
dc60614
e0ceb80
3b2acfc
123aa2d
d3c34a7
d7a3ae9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it may be simpler to build a map based on the match which will avoid having to maintain
ACCELERATOR_TO_URI_REF
, the framework constants, and this string in favor of the map.Something like:
The TF2 bookkeeping can be done here as well.
Updating with a new container uri or framework will only require adding to the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm uncertain of exposing
value_converter
as well as it's not a module we currently expose or provide documentation/usage on. It mainly used by the enhanced portions of the library.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we potentially move
value_converter
intoaiplatform.utils
so thataiplatform.helpers
contains only methods intended for external use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about using a flag here, since with PyTorch containers - there are three flavors
xla
,cpu
, andgpu
. But as this seems version dependent, the method could handle searching for the correct URI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should accept
cpu
,gpu
for now to make this more extendable if we support other accelerators in the future.