Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Made display_name parameter optional for most calls #882

Merged
merged 23 commits into from
Apr 5, 2022
Merged

feat: Made display_name parameter optional for most calls #882

merged 23 commits into from
Apr 5, 2022

Commits on Feb 5, 2022

  1. feat: Made display_name optional for most calls

    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    65224d6 View commit details
    Browse the repository at this point in the history

  2. Reverted the change to _Dataset.create interface

    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b2958ae View commit details
    Browse the repository at this point in the history

  3. Extracted the display name generation to the _generate_display_name m… 

    …ethod
    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b0e19fe View commit details
    Browse the repository at this point in the history

  4. Made Model.batch_predict(job_display_name=) optional

    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    47563a0 View commit details
    Browse the repository at this point in the history

  5. Removed the unused imports

    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b3234dc View commit details
    Browse the repository at this point in the history

  6. Added a unit test

    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    c0d2aee View commit details
    Browse the repository at this point in the history

  7. Fixed getting the class name.

    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    f08c19b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Fixed code style

    @Ark-kun
    Ark-kun committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    9e5a800 View commit details
    Browse the repository at this point in the history

  2. Fixed the unit test

    @Ark-kun
    Ark-kun committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    1cfc9c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

    @kweinmeister
    kweinmeister committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    54c658f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

    @kweinmeister
    kweinmeister committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    701bbbd View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Restore the parameter ordering as requested by reviewer 

    The parameter default values had to be removed due to Python's syntax.
    @Ark-kun
    Ark-kun committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    00977be View commit details
    Browse the repository at this point in the history

  2. Marked the BatchPredictJob.create job_display_name parameter as optional

    @Ark-kun
    Ark-kun committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    8c8c8aa View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

    @kweinmeister
    kweinmeister committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    8e69108 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

    @kweinmeister
    kweinmeister committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    560b0a8 View commit details
    Browse the repository at this point in the history

  2. Restored the parameter order in jobs.py as asked by reviewer

    @Ark-kun
    Ark-kun committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    dfd164d View commit details
    Browse the repository at this point in the history

  3. Added bug link to the TODO comments

    @Ark-kun
    Ark-kun committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    93acea0 View commit details
    Browse the repository at this point in the history

  4. Annotated _Dataset.create(display_name) as Optional

    @Ark-kun
    Ark-kun committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    348b51c View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Changed docstringg as asked by the reviewer

    @Ark-kun
    Ark-kun committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    57b1241 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. Implemented the reviewer request: Removed the Optional[str] annotatio… 

    …ns where default value cannot be specified
    @Ark-kun
    Ark-kun committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    fee7b89 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

    @Ark-kun
    Ark-kun committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    a695fb5 View commit details
    Browse the repository at this point in the history

  3. Fixed code formatting

    @Ark-kun
    Ark-kun committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    92c1eaf View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

    @kweinmeister
    kweinmeister committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    3ce47f6 View commit details
    Browse the repository at this point in the history