New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Made it easier to use the latest framework version when calling Model.upload_* #997
Merged
sasha-gitg
merged 1 commit into
googleapis:main
from
Ark-kun:chore--Made-it-easier-to-request-the-latest-framework-version-when-calling-Model.upload_-
Feb 3, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lling Model.upload_* Goal: make it easier for the calling functions to ask for the latest framework version. It turns out that the current approach complicates calling the upload_* functions, because there is no values of the *_version parameter that mean "latest version". This leads to the need to have different code paths depending on whether the user has given an explicit version value. Example of the problem: ```python def my_import_xgboost_model( model_path: str, xgboost_version: Optional[str] = None, ): if xgboost_version: aiplatfor.Model.upload_xgboost_model(model_path=model_path, xgboost_version=xgboost_version) else: aiplatfor.Model.upload_xgboost_model(model_path=model_path) ``` With this small change, the call is simplified: ```python def my_import_xgboost_model( model_path: str, xgboost_version: Optional[str] = None, ): aiplatfor.Model.upload_xgboost_model(model_path=model_path, xgboost_version=xgboost_version) ``` P.S. It would be great if the `get_prebuilt_prediction_container_uri` function supported the "latest version" feature.
Ark-kun
force-pushed
the
chore--Made-it-easier-to-request-the-latest-framework-version-when-calling-Model.upload_-
branch
from
February 3, 2022 04:18
a40b730
to
e69b58e
Compare
sasha-gitg
approved these changes
Feb 3, 2022
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
… - Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…- Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
… - Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…- Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: make it easier for the calling functions to ask for the latest framework version.
It turns out that the current approach complicates calling the upload_* functions, because there is no values of the *_version parameter that mean "latest version". This leads to the need to have different code paths depending on whether the user has given an explicit version value.
Example of the problem:
With this small change, the call is simplified:
P.S. It would be great if the
get_prebuilt_prediction_container_uri
supported the "latest version" feature.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕