Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Python 3.10 #143

Merged
merged 2 commits into from Nov 15, 2022
Merged

feat: add support for Python 3.10 #143

merged 2 commits into from Nov 15, 2022

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Nov 10, 2022 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #109 馃

@ziegenberg
feat: add support for Python 3.10
bddd116 
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg requested a review from a team as a code owner November 10, 2022 19:04
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 10, 2022
@Mariatta
Copy link
Contributor

Can we do Python 3.11 too?

@ziegenberg
Copy link
Contributor Author

Can we do Python 3.11 too?

Sure. I would put it into a separate PR

@ziegenberg
Copy link
Contributor Author

@Mariatta could you give the CI a little push to start the testing? Would be awesome :)

@ziegenberg ziegenberg mentioned this pull request Nov 10, 2022
Merged
4 tasks
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 15, 2022
@parthea parthea merged commit 63ca888 into googleapis:main Nov 15, 2022
@release-please release-please bot mentioned this pull request Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python 3.10 compatibility
4 participants
@ziegenberg @Mariatta @parthea @yoshi-kokoro