feat: update all protos and pb2 files #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
force-pushed
the
use-protos-from-googleapis-directly
branch
from
ea8384d
to
dd2ffab
Compare
parthea
added
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
parthea
force-pushed
the
use-protos-from-googleapis-directly
branch
2 times, most recently
from
46ba7a5
to
18b37a9
Compare
parthea
force-pushed
the
use-protos-from-googleapis-directly
branch
from
968e7fc
to
af806be
Compare
parthea
force-pushed
the
use-protos-from-googleapis-directly
branch
from
af806be
to
369a626
Compare
parthea
force-pushed
the
use-protos-from-googleapis-directly
branch
from
70592f7
to
4a3671f
Compare
busunkim96
reviewed
Mar 17, 2022
Comment on lines
-55
to
-56
| // The list of features enabled on this endpoint. | ||
| repeated string features = 4; |
There was a problem hiding this comment.
This looks like a breaking change.
There was a problem hiding this comment.
Great catch! I'll update the release notes. This breaking change is from googleapis/googleapis@ca1372c. There is a comment that says features field is no longer used. It has been removed from the API runtime for awhile. Based on the fact that's it's already removed from the API runtime, the breaking change already happened on the backend and existing code would already fail. In this case, we won't bump the major version.
busunkim96
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83 馃
BEGIN_COMMIT_OVERRIDE
feat: update all protos and pb2 files
feat: add google/api/error_reason.proto
feat: add google/api/visibility.proto
feat: add google/type/decimal.proto
feat: add google/type/interval.proto
feat: add google/type/localized_text.proto
feat: add google/type/phone_number.proto
fix: remove deprecated fields
aliasesandfeaturesfrom google/api/endpoint.protoEND_COMMIT_OVERRIDE