Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore unknown fields in rest streaming. #651

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

MarkDaoust
Copy link
Contributor

@MarkDaoust MarkDaoust commented May 6, 2024

If the api adds a new field to a streaming response, it shouldn't break old clients.

We found this in the google.ai.generativelanguage API. Colab forces our clients to use rest, so all our streaming examples broke when the API team rolled out a new field.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

If the api adds a new field to a stremaing response, it shouldn't break old clients.

We found this in the google.ai.generativelanguage API. Colab forces our clients to use rest, so all our streaming examples broke when the API team rolled out a new field.
@MarkDaoust MarkDaoust requested review from a team as code owners May 6, 2024 16:41
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 6, 2024
@parthea parthea changed the title Ignore unknown fields in rest streaming. fix: Ignore unknown fields in rest streaming. May 6, 2024
Copy link

馃 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@parthea parthea enabled auto-merge (squash) June 4, 2024 11:42
@parthea parthea merged commit 1203fb9 into googleapis:main Jun 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants