Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add caching to GapicCallable #666

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Jun 4, 2024

Opening a new PR to restore the features in #527 which were reverted in #665 due to #660

cc @daniel-sanche

@parthea parthea requested review from a team as code owners June 4, 2024 14:29
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 4, 2024
@parthea parthea changed the title Optimize gapic callable feat: add caching to GapicCallable Jun 4, 2024
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 4, 2024
@parthea parthea assigned daniel-sanche and unassigned vchudnov-g Jun 4, 2024
@parthea parthea marked this pull request as draft June 4, 2024 14:32
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche
Copy link
Contributor

@parthea Just changed the metadata type to a list, and added types to a docstring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants