This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
test: fix vpcsc tests #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from https://github.com/googleapis/python-asset/blob/ce011b3b922bd9aac17d455c105331d09f6b8e31/tests/system/test_vpcsc.py at which point the VPCSC tests seem to have been passing
google-cla
bot
added
the
cla: yes
arithmetic1728
approved these changes
Aug 24, 2020
|
It seems the fixup keywords scripts just fill up the keywords one by one in order, even if some keywords are missing, so there can be key/value pair mismatch. |
|
@software-dov Is that the expected behavior for the fixup script? The VPCSC tests only to check if a request is rejected/accepted by the org policy so the actual request may be invalid. python-asset/tests/system/test_vpcsc.py Line 27 in ce011b3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from https://github.com/googleapis/python-asset/blob/ce011b3b922bd9aac17d455c105331d09f6b8e31/tests/system/test_vpcsc.py at which point the VPCSC tests seem to have been passing