New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load data with user defined schema #150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 75.8% 29.3% -46.51%
==========================================
Files 8 8
Lines 1546 1556 +10
==========================================
- Hits 1172 456 -716
- Misses 374 1100 +726
Continue to review full report at Codecov.
|
Supersedes #131 |
This looks great. Any feedback @tswast ? @aktech did you run the tests? Otherwise I will. (Travis integration tests don't work on PRs because of the auth keys) @tswast more generally, do you think it's OK to merge these small PRs that look good, so the tests run on master, and then correct in the 5% of cases where it fails? Or we should run the tests on an 'auth-enabled' travis first? |
LGTM. @maxim-lian So long as whomever merges keeps an eye on the master build and fixes / reverts based on the outcome, I'm okay merging without requiring an auth-enabled Travis. |
Thanks for the quick reply and merging.
Yes, I did ran the tests locally as well as on travis: |
The
to_gbp
function fails when there is a user-defined schema which is slightly different from the schema of DataFrame.Traceback:
The primary reason for this is that the
load_data
function ignores theschema
argument.Solution: The
schema
argument is now passed to theload_chunks
function insideload_data
function. A suitable integration test has been added.