Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] skip _try_credentials check for to_gbq #207

Merged
merged 3 commits into from
Aug 31, 2018
Merged

[BUG] skip _try_credentials check for to_gbq #207

merged 3 commits into from
Aug 31, 2018

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 31, 2018

Don't do a query read when all you need to write is write credentials.

Closes #202

@tswast
[BUG] skip _try_credentials check for to_gbq
2026671 
Don't do a query read when all you need to write is write credentials.
@tswast tswast requested a review from max-sixty August 31, 2018 19:03
@tswast
Copy link
Collaborator Author

tswast commented Aug 31, 2018 •
edited
Loading

Build running at https://travis-ci.org/tswast/pandas-gbq/builds/423155488 https://travis-ci.org/tswast/pandas-gbq/builds/423188575

max-sixty
max-sixty approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit 3f3192f into googleapis:master Aug 31, 2018
@tswast tswast deleted the issue-202-no-try-credentials branch August 31, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tswast @max-sixty