Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: modifies latency due to flakybot issues #781

Merged
merged 2 commits into from
Jun 10, 2024
Merged

bug: modifies latency due to flakybot issues #781

merged 2 commits into from
Jun 10, 2024

Conversation

chalmerlowe
Copy link
Collaborator

Testing a slightly longer delay for latency due to some flakybot issues.

Fixes #775 馃

@chalmerlowe chalmerlowe requested review from a team as code owners June 10, 2024 14:01
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 10, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jun 10, 2024
@chalmerlowe
Copy link
Collaborator Author

chalmerlowe commented Jun 10, 2024 •
edited
Loading

@Linchin

This repo fails in the continous testing cycle. (See #775). I would like to merge this PR to main (provided all other tests are successful) and let it ruminate for a while to see how things play out.

To that end, I want to:

  • Get a release pushed out before we merge this
  • Tag the next release candidate as Do not release
  • Merge this PR
  • Let continuous testing do its thing for a while to see if the same intermittent issue appears in flakybot again
  • If we appear to have success remove the Do not release tag

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2024
@Linchin
Copy link
Contributor

Linchin commented Jun 10, 2024

SG. I think we need to be careful making a release with this change though, this may break some user code.

@chalmerlowe chalmerlowe merged commit b5e43a9 into main Jun 10, 2024
26 checks passed
@chalmerlowe chalmerlowe deleted the latency-value branch June 10, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Linchin approved these changes

@farhan0102 farhan0102 Awaiting requested review from farhan0102 farhan0102 is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@leahecole leahecole

Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests.system.test_gbq.TestReadGBQIntegration: test_timeout_configuration failed
4 participants
@chalmerlowe @Linchin @leahecole @yoshi-kokoro