Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecated SearchAssignments in favor of SearchAllAssignments #157

Merged
merged 2 commits into from Sep 1, 2021

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 1, 2021

Fixes #142

  • Regenerate this pull request now.

PiperOrigin-RevId: 394129271

Source-Link: googleapis/googleapis@2c7f233

Source-Link: googleapis/googleapis-gen@711f2cd

feat: Reservation objects now contain a creation time and an update time
feat: Added commitment_start_time to capacity commitments
feat: Force deleting capacity commitments is allowed while reservations with active assignments
feat: ML_EXTERNAL job type is supported
feat: Optional id can be passed into CreateCapacityCommitment and CreateAssignment
docs: Clarified docs for None assignments
fix: Fixed pattern for BiReservation object, where bireservation changed to biReservation

…eat: Reservation objects now contain a creation time and an update time feat: Added commitment_start_time to capacity commitments feat: Force deleting capacity commitments is allowed while reservations with active assignments exist feat: ML_EXTERNAL job type is supported feat: Optional id can be passed into CreateCapacityCommitment and CreateAssignment docs: Clarified docs for None assignments fix!: Fixed pattern for BiReservation object BREAKING_CHANGE: Changed from `bireservation` to `biReservation`

PiperOrigin-RevId: 394129271

Source-Link: googleapis/googleapis@2c7f233

Source-Link: https://github.com/googleapis/googleapis-gen/commit/711f2cd1d3072ad3d974a40a0c19a3c873a328b1
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Sep 1, 2021
@parthea parthea changed the title feat: Deprecated SearchAssignments in favor of SearchAllAssignments feat: Reservation objects now contain a creation time and an update time feat: Added commitment_start_time to capacity commitments feat: Force deleting capacity commitments is allowed ... feat: Deprecated SearchAssignments in favor of SearchAllAssignments Sep 1, 2021
@parthea
Copy link
Contributor

@parthea parthea commented Sep 1, 2021

@tswast PTAL

tswast
tswast approved these changes Sep 1, 2021
@tswast tswast merged commit dacdf5a into main Sep 1, 2021
10 checks passed
@tswast tswast deleted the owl-bot-c49417fd-254c-4de5-90b8-e60e70ad879d branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants