Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

chore: prevent normalization of semver versioning #91

Merged
merged 1 commit into from Apr 15, 2021

Conversation

dandhlee
Copy link
Contributor

When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from -patch to .patch which is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.

@dandhlee dandhlee requested review from a team and tswast April 14, 2021 23:31
@product-auto-label product-auto-label bot added the api: bigqueryreservation Issues related to the googleapis/python-bigquery-reservation API. label Apr 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@tswast tswast merged commit 1d32d3c into master Apr 15, 2021
@tswast tswast deleted the remove-semver-normalization branch April 15, 2021 23:20
dandhlee added a commit that referenced this pull request Apr 21, 2021
tswast pushed a commit that referenced this pull request Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigqueryreservation Issues related to the googleapis/python-bigquery-reservation API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants