Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sets cache support to false, removes upper req limit #499

Merged
merged 4 commits into from
Nov 10, 2022
Merged

fix: Sets cache support to false, removes upper req limit #499

merged 4 commits into from
Nov 10, 2022

Conversation

chalmerlowe
Copy link
Collaborator

This PR does two things:

  • Updates the upper bound on requirements for python-bigquery-sqlalchemy
  • Sets the status of the BigQueryDialect attribute supports_statement_cache to False

At this time, it is not yet clear whether BigQuery, out of the box, supports SQL statement caching. In an effort to clear the failing tests and allow interoperability with sqlalchemy > 1.4.27, we are opting to provide these limited changes while additional work is pursued to confirm that BigQuery connector libraries and APIs support statement caching.

Fixes #385 🦕

A follow on issue (TODO: add issue number here), will be submitted prior to closing this PR to ensure that resources are applied to confirming statement caching support.

TODO add a comment to the code regarding the supports_statement_cache = False purpose and next steps.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Oct 25, 2022
@chalmerlowe
Copy link
Collaborator Author

chalmerlowe commented Oct 25, 2022 •
edited

20221025: the kokoro prerelease failure is a known entity (issues with shapely) and will be corrected when python-bigquery release 3.3.6 is cut. This is no longer an issue as the 3.3.6 merge is now complete.

@chalmerlowe chalmerlowe changed the title Sets cache support to false, removes upper req limit fix: Sets cache support to false, removes upper req limit Oct 26, 2022
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@chalmerlowe chalmerlowe mentioned this pull request Nov 3, 2022
Closed
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@chalmerlowe
Copy link
Collaborator Author

20221104: there is a prerelease issue with parsing the sqlalchemy version number.
The prerelease version number is x.x.0b2.
The patch value of 0b2 cannot be converted to an integer and thus the prerelease test fails.

@chalmerlowe chalmerlowe marked this pull request as ready for review November 9, 2022 12:39
@chalmerlowe chalmerlowe requested a review from a team as a code owner November 9, 2022 12:39
@chalmerlowe chalmerlowe requested review from a team and mhaligowski November 9, 2022 12:39
@chalmerlowe
Copy link
Collaborator Author

The SQLAlchemy compliance issue should be corrected as soon as PR #501 is merged with main
See above for note about the failing Prerelease Test.

@parthea can you help with getting these two PRs across the finish line?

@chalmerlowe chalmerlowe mentioned this pull request Nov 10, 2022
Merged
@chalmerlowe chalmerlowe merged commit be63adc into main Nov 10, 2022
@chalmerlowe chalmerlowe deleted the version-fix branch November 10, 2022 18:21
@release-please release-please bot mentioned this pull request Nov 10, 2022
Merged
atkincaid74 added a commit to KoffieLabs/python-bigquery-sqlalchemy that referenced this pull request Dec 19, 2022
@atkincaid74
REVERT MERGE
94ef139 
Revert "docs: fix changelog header to consistent size (googleapis#461)"

This reverts commit 177e70a.

Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)"

This reverts commit acc9274.

Revert "chore(main): release 1.4.4 (googleapis#462)"

This reverts commit 06c0270.

Revert "fix: require python 3.7+ (googleapis#468)"

This reverts commit 52ec808.

Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)"

This reverts commit e894dfa.

Revert "chore: add hashes to requirements.txt' (googleapis#483)"

This reverts commit cc13fe3.

Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)"

This reverts commit 484d524.

Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)"

This reverts commit 4f90d90.

Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)"

This reverts commit 4b37fed.

Revert "chore(python): exclude setup.py in renovate config (googleapis#487)"

This reverts commit 9ffc736.

Revert "chore(deps): update all dependencies (googleapis#488)"

This reverts commit 189af9b.

Revert "chore: detect samples tests in nested directories (googleapis#492)"

This reverts commit f566371.

Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)"

This reverts commit 4f72d4e.

Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)"

This reverts commit f188944.

Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)"

This reverts commit be63adc.

Revert "fix: updates test to account for UTC in failing test (googleapis#501)"

This reverts commit a050ccf.

Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)"

This reverts commit 0f6be67.

Revert "fix: use packaging version parser instead of string splitting (googleapis#513)"

This reverts commit bb7f6a7.

Revert "chore(main): release 1.5.0 (googleapis#469)"

This reverts commit 1ffab57.

Revert "chore: addressed lint issue with __version__ (googleapis#534)"

This reverts commit 4e17259.

Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)"

This reverts commit 57794c3.
atkincaid74 added a commit to KoffieLabs/python-bigquery-sqlalchemy that referenced this pull request Mar 16, 2023
@atkincaid74
REVERT MERGE
c4f5f91 
Revert "docs: fix changelog header to consistent size (googleapis#461)"

This reverts commit 177e70a.

Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)"

This reverts commit acc9274.

Revert "chore(main): release 1.4.4 (googleapis#462)"

This reverts commit 06c0270.

Revert "fix: require python 3.7+ (googleapis#468)"

This reverts commit 52ec808.

Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)"

This reverts commit e894dfa.

Revert "chore: add hashes to requirements.txt' (googleapis#483)"

This reverts commit cc13fe3.

Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)"

This reverts commit 484d524.

Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)"

This reverts commit 4f90d90.

Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)"

This reverts commit 4b37fed.

Revert "chore(python): exclude setup.py in renovate config (googleapis#487)"

This reverts commit 9ffc736.

Revert "chore(deps): update all dependencies (googleapis#488)"

This reverts commit 189af9b.

Revert "chore: detect samples tests in nested directories (googleapis#492)"

This reverts commit f566371.

Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)"

This reverts commit 4f72d4e.

Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)"

This reverts commit f188944.

Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)"

This reverts commit be63adc.

Revert "fix: updates test to account for UTC in failing test (googleapis#501)"

This reverts commit a050ccf.

Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)"

This reverts commit 0f6be67.

Revert "fix: use packaging version parser instead of string splitting (googleapis#513)"

This reverts commit bb7f6a7.

Revert "chore(main): release 1.5.0 (googleapis#469)"

This reverts commit 1ffab57.

Revert "chore: addressed lint issue with __version__ (googleapis#534)"

This reverts commit 4e17259.

Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)"

This reverts commit 57794c3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@mhaligowski mhaligowski Awaiting requested review from mhaligowski

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support SQLAlchemy 1.4.28+
3 participants
@chalmerlowe @parthea @yoshi-kokoro