Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update resource docstrings #60

Merged
merged 4 commits into from Oct 16, 2020
Merged

doc: update resource docstrings #60

merged 4 commits into from Oct 16, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Sep 17, 2020 •
edited

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/04ad20ac-18df-44ad-9e60-73eb73288cbc/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@477764c
Source-Link: googleapis/synthtool@e0ae456
Source-Link: googleapis/synthtool@9b0da52

@yoshi-automation yoshi-automation requested a review from a team September 17, 2020 12:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Sep 18, 2020
@tswast tswast changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. doc: update resource docstrings Oct 13, 2020
@tswast tswast self-requested a review October 13, 2020 21:15
@yoshi-automation yoshi-automation requested a review from a team as a code owner October 14, 2020 12:34
leahecole
leahecole reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these samples where we have to be using the cloud specific build projects?

@tswast
Copy link
Contributor

tswast commented Oct 15, 2020

@leahecole

Are these samples where we have to be using the cloud specific build projects?

/shrug

They only access public data or data they create themselves as part of the test fixture. They don't rely on any private long-lived data, so should be able to be run anywhere.

@leahecole
Copy link
Contributor

Okee dokes - I double checked and the addition of this env var just opens up the possibility and isn't a commitment. So given the /shrug nature of your response, it should be fine in the context of this PR as is :)

@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@tswast
Copy link
Contributor

tswast commented Oct 15, 2020

Test failures are confusing

/tmpfs/src/github/python-bigquery-storage/samples/to_dataframe/.nox/py-3-7/lib/python3.7/site-packages/google/cloud/bigquery/magics.py in _make_bqstorage_client(use_bqstorage_api, credentials)
    605     try:
--> 606         from google.cloud import bigquery_storage_v1beta1
    607     except ImportError as err:

ImportError: cannot import name 'bigquery_storage_v1beta1' from 'google.cloud' (/tmpfs/src/github/python-bigquery-storage/google/cloud/__init__.py)

Looks like this hasn't included the changes from #64

@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 16, 2020
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@yoshi-automation
changes without context
b2677c2 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
chore(python): use BUILD_SPECIFIC_GCLOUD_PROJECT for samples
a32abd4 
https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32

`BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 30 13:06:03 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4
Source-Link: googleapis/synthtool@9b0da52
@yoshi-automation
chore(python): use 'setup.py' to detect repo root
0338360 
Closes #792

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Fri Oct 9 15:06:33 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: e0ae456852bf22f38796deb79cff30b516fde244
Source-Link: googleapis/synthtool@e0ae456
@yoshi-automation
build(python): samples tests should pass if no samples exist
85a3380 
Source-Author: Daniel Sanche <d.sanche14@gmail.com>
Source-Date: Wed Oct 14 08:00:06 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 477764cc4ee6db346d3febef2bb1ea0abf27de52
Source-Link: googleapis/synthtool@477764c
@tswast tswast merged commit a0a99f6 into master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoshi-automation @tswast @leahecole @yoshi-kokoro