Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add system test SQL to run tests locally #74

Merged
merged 5 commits into from
Dec 22, 2020
Merged

test: add system test SQL to run tests locally #74

merged 5 commits into from
Dec 22, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 16, 2020 •
edited

I was missing the public_samples_copy dataset when trying to run the
system tests locally. This adds some SQL code to at least be able to manually
create the expected table.

Also, it is unnecessary to use the mock backfill package now that
Python 3.6+ is required.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #14

@tswast
test: add system test SQL to run tests locally
eccc65c 
I was missing the `public_samples_copy` dataset when trying to run the
system tests locally.

Also, it is unnecessary to use the `mock` backfill package now that
Python 3.6+ is required.
@tswast tswast requested a review from a team October 16, 2020 15:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2020
@tswast tswast mentioned this pull request Oct 16, 2020
Merged
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Oct 22, 2020
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Nov 10, 2020
@tswast tswast merged commit 3218893 into googleapis:master Dec 22, 2020
@tswast tswast deleted the refactor-mock branch December 22, 2020 15:33
@meredithslota meredithslota mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tswast @stephaniewang526