Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing Storage Billing model property to BQ Datasets #1643

Merged
merged 10 commits into from Sep 15, 2023

Conversation

sriramsridhar
Copy link
Contributor

@sriramsridhar sriramsridhar commented Aug 16, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes Issue #1639 🦕

@google-cla
Copy link

google-cla bot commented Aug 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 16, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Aug 16, 2023
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2023
@tswast
Copy link
Contributor

tswast commented Aug 16, 2023

Thanks so much for the contribution @sriramsridhar !

@sriramsridhar
Copy link
Contributor Author

@obada-ab Please review this pr and share your comments

@sriramsridhar
Copy link
Contributor Author

@tswast Please merge this PR

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2023
@storage_billing_model.setter
def storage_billing_model(self, value):
if not isinstance(value, str) and value is not None:
raise ValueError("Pass a string, or None")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing some unit tests for some of these branches:

google/cloud/bigquery/dataset.py                               352      2     81      3    99%   780, 781->783, 784

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any ETA on this ?

@SudoSpartanDan
Copy link

Is there an ETA on this feature? Our team is waiting on this to be able to set this attribute.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 15, 2023
@tswast tswast enabled auto-merge (squash) September 15, 2023 16:22
@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2023
@tswast tswast merged commit 5deba50 into googleapis:main Sep 15, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants