Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow storage_billing_model to be explicitly set to None to use project default value #1665

Merged
merged 2 commits into from Oct 2, 2023
Merged

fix: allow storage_billing_model to be explicitly set to None to use project default value #1665

merged 2 commits into from Oct 2, 2023

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 2, 2023

Follow-up to #1643

Fixes internal issue 302750597 🦕

@tswast tswast requested review from a team as code owners October 2, 2023 14:35
@tswast tswast requested a review from obada-ab October 2, 2023 14:35
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 2, 2023
@chalmerlowe
Copy link
Contributor

This does not account for the fourth option that is available:

STORAGE_BILLING_MODEL_UNSPECIFIED

That should at least be called out in the comment.

@tswast
@Linchin

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 2, 2023
@tswast
Copy link
Contributor Author

tswast commented Oct 2, 2023

That should at least be called out in the comment.

Added!

IMO, the less client-side logic the better, but adding this in the docs makes sense to me.

@shollyman shollyman requested review from chalmerlowe and Linchin and removed request for obada-ab October 2, 2023 15:48
chalmerlowe
chalmerlowe approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 514d3e1 into main Oct 2, 2023
18 of 20 checks passed
@tswast tswast deleted the b302750597-storage_billing_model branch October 2, 2023 16:56
@release-please release-please bot mentioned this pull request Sep 29, 2023
Merged
This was referenced Oct 10, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@Linchin Linchin Awaiting requested review from Linchin

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tswast @chalmerlowe