Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: support OpenTelemetry >= 1.1.0 #1050

merged 1 commit into from Nov 8, 2021

deps: support OpenTelemetry >= 1.1.0 #1050

merged 1 commit into from Nov 8, 2021


Copy link

@plamut plamut commented Nov 5, 2021

Closes #1038.

This PR makes sure that the tracing logic is compatible with OpenTelemetry >= 1.1.0 (the first version that supports type checks), and that tests actually fail if a future python-opentelemetry version contains backward-incompatible changes in its API (previously the tests would just be skipped).

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from tswast Nov 5, 2021
@plamut plamut requested review from as code owners Nov 5, 2021
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
tswast approved these changes Nov 8, 2021
except (ImportError, AttributeError) as exc: # pragma: NO COVER
msg = "Error importing from opentelemetry, is the installed version compatible?"
raise ImportError(msg) from exc
Copy link

@tswast tswast Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on raising this here. I'd rather we catch incompatibilities early.

@tswast tswast changed the title fix: support OpenTelemetry >= 1.1.0 deps: support OpenTelemetry >= 1.1.0 Nov 8, 2021
@tswast tswast merged commit 4616cd5 into googleapis:main Nov 8, 2021
14 checks passed
@plamut plamut deleted the iss-1038 branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants