Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make TimePartitioning repr evaluable #110

Merged
merged 14 commits into from Oct 13, 2020

Conversation

@francois-baptiste
Copy link
Contributor

@francois-baptiste francois-baptiste commented May 18, 2020

Fixes #109 馃

@googlebot
Copy link

@googlebot googlebot commented May 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

Loading

@francois-baptiste
Copy link
Contributor Author

@francois-baptiste francois-baptiste commented May 18, 2020

@googlebot I signed it!

Loading

@googlebot
Copy link

@googlebot googlebot commented May 18, 2020

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

Loading

Copy link
Contributor

@plamut plamut left a comment

The main concern with this change, while nice on its own, is that it can break existing user code as the failed tests show. I'm not sure if evaluability of the representation is really worth it.

@shollyman Your thoughts?

Loading

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
Loading
@francois-baptiste
Copy link
Contributor Author

@francois-baptiste francois-baptiste commented May 19, 2020

Thank you for your help @plamut.
I reworked the pull request from scratch. The properties from TimePartitioning object are now converted from the REST API to the python API in the repr method.

Loading

@francois-baptiste francois-baptiste changed the title Makes TimePartitioning printable representation evaluable fix: makes TimePartitioning printable representation evaluable May 25, 2020
Copy link
Contributor

@plamut plamut left a comment

This is much better, thanks for the refactoring! Changing only the representation is much less of a concern than changing a method signature.

One of the tests broke, though, and should be fixed, the rest are some very minor comments.
(not sure why the CI status is not reported, though...)

Loading

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/table.py Show resolved Hide resolved
Loading
tests/unit/test_table.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
Loading
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
@googlebot
Copy link

@googlebot googlebot commented May 25, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

Loading

@googlebot
Copy link

@googlebot googlebot commented May 25, 2020

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

Loading

@tseaver tseaver changed the title fix: makes TimePartitioning printable representation evaluable fix: make TimePartitioning repr evaluable Jul 29, 2020
@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 30, 2020

@shollyman Any follow up on the open internal questions you raised?

Loading

@plamut
Copy link
Contributor

@plamut plamut commented Aug 6, 2020

@shollyman Friendly ping. :) Any updates on those internal questions to date?

Loading

@plamut plamut requested a review from cguardia Aug 28, 2020
@meredithslota meredithslota requested a review from shollyman Aug 28, 2020
Copy link
Contributor

@cguardia cguardia left a comment

Looks ready, but seems like nothing can be done until the internal issue is resolved.

Loading

@shollyman
Copy link
Contributor

@shollyman shollyman commented Sep 15, 2020

Documentation for behavior is getting updated. Lack of value will be treated as DAY interval.

Loading

tswast
tswast approved these changes Oct 6, 2020
@tswast tswast requested a review from as a code owner Oct 6, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 20f473b into googleapis:master Oct 13, 2020
9 checks passed
Loading
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 19, 2020
馃 I have created a release \*beep\* \*boop\* 
---
## [2.2.0](https://www.github.com/googleapis/python-bigquery/compare/v2.1.0...v2.2.0) (2020-10-19)


### Features

* add method api_repr for table list item ([#299](https://www.github.com/googleapis/python-bigquery/issues/299)) ([07c70f0](https://www.github.com/googleapis/python-bigquery/commit/07c70f0292f9212f0c968cd5c9206e8b0409c0da))
* add support for listing arima, automl, boosted tree, DNN, and matrix factorization models ([#328](https://www.github.com/googleapis/python-bigquery/issues/328)) ([502a092](https://www.github.com/googleapis/python-bigquery/commit/502a0926018abf058cb84bd18043c25eba15a2cc))
* add timeout paramter to load_table_from_file and it dependent methods ([#327](https://www.github.com/googleapis/python-bigquery/issues/327)) ([b0dd892](https://www.github.com/googleapis/python-bigquery/commit/b0dd892176e31ac25fddd15554b5bfa054299d4d))
* add to_api_repr method to Model ([#326](https://www.github.com/googleapis/python-bigquery/issues/326)) ([fb401bd](https://www.github.com/googleapis/python-bigquery/commit/fb401bd94477323bba68cf252dd88166495daf54))
* allow client options to be set in magics context ([#322](https://www.github.com/googleapis/python-bigquery/issues/322)) ([5178b55](https://www.github.com/googleapis/python-bigquery/commit/5178b55682f5e264bfc082cde26acb1fdc953a18))


### Bug Fixes

* make TimePartitioning repr evaluable ([#110](https://www.github.com/googleapis/python-bigquery/issues/110)) ([20f473b](https://www.github.com/googleapis/python-bigquery/commit/20f473bfff5ae98377f5d9cdf18bfe5554d86ff4)), closes [#109](https://www.github.com/googleapis/python-bigquery/issues/109)
* use version.py instead of pkg_resources.get_distribution ([#307](https://www.github.com/googleapis/python-bigquery/issues/307)) ([b8f502b](https://www.github.com/googleapis/python-bigquery/commit/b8f502b14f21d1815697e4d57cf1225dfb4a7c5e))


### Performance Improvements

* add size parameter for load table from dataframe and json methods ([#280](https://www.github.com/googleapis/python-bigquery/issues/280)) ([3be78b7](https://www.github.com/googleapis/python-bigquery/commit/3be78b737add7111e24e912cd02fc6df75a07de6))


### Documentation

* update clustering field docstrings ([#286](https://www.github.com/googleapis/python-bigquery/issues/286)) ([5ea1ece](https://www.github.com/googleapis/python-bigquery/commit/5ea1ece2d911cdd1f3d9549ee01559ce8ed8269a)), closes [#285](https://www.github.com/googleapis/python-bigquery/issues/285)
* update snippets samples to support version 2.0 ([#309](https://www.github.com/googleapis/python-bigquery/issues/309)) ([61634be](https://www.github.com/googleapis/python-bigquery/commit/61634be9bf9e3df7589fc1bfdbda87288859bb13))


### Dependencies

* add protobuf dependency ([#306](https://www.github.com/googleapis/python-bigquery/issues/306)) ([cebb5e0](https://www.github.com/googleapis/python-bigquery/commit/cebb5e0e911e8c9059bc8c9e7fce4440e518bff3)), closes [#305](https://www.github.com/googleapis/python-bigquery/issues/305)
* require pyarrow for pandas support ([#314](https://www.github.com/googleapis/python-bigquery/issues/314)) ([801e4c0](https://www.github.com/googleapis/python-bigquery/commit/801e4c0574b7e421aa3a28cafec6fd6bcce940dd)), closes [#265](https://www.github.com/googleapis/python-bigquery/issues/265)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

10 participants