fix: remove query text from exception message, use exception.debug_message instead
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage` instead Since query text can potentially contain sensitive information, remove it from the default exception message. This information is useful for debugging, so provide a `debug_message` attribute, which is not included in the exception representation (and thus the logs). Fixes internal issue 211616590
product-auto-label
bot
added
the
api: bigquery
busunkim96
approved these changes
Jan 12, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 13, 2022
🤖 I have created a release *beep* *boop* --- ## [2.32.0](v2.31.0...v2.32.0) (2022-01-12) ### Features * support authorized dataset entity ([#1075](#1075)) ([c098cd0](c098cd0)) ### Bug Fixes * remove query text from exception message, use `exception.debug_message` instead ([#1105](#1105)) ([e23114c](e23114c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…essage` instead (googleapis#1105) Since query text can potentially contain sensitive information, remove it from the default exception message. This information is useful for debugging, so provide a `debug_message` attribute, which is not included in the exception representation (and thus the logs). Fixes internal issue 211616590
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
🤖 I have created a release *beep* *boop* --- ## [2.32.0](googleapis/python-bigquery@v2.31.0...v2.32.0) (2022-01-12) ### Features * support authorized dataset entity ([googleapis#1075](googleapis#1075)) ([c098cd0](googleapis@c098cd0)) ### Bug Fixes * remove query text from exception message, use `exception.debug_message` instead ([googleapis#1105](googleapis#1105)) ([e23114c](googleapis@e23114c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since query text can potentially contain sensitive information, remove it from
the default exception message. This information is useful for debugging, so
provide a
debug_messageattribute, which is not included in the exceptionrepresentation (and thus the logs).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 211616590
🦕