fix: load_table_from_dataframe method for issue 1692 #1698
Conversation
product-auto-label
bot
added
size: s
|
Please keep titles less than 50 characters. |
Gaurang033
force-pushed
the
feature/fix_1692_load_table_from_dataframe
branch
2 times, most recently
from
ed452fb
to
6dd6a79
Compare
Gaurang033
changed the title
Gaurang033
force-pushed
the
feature/fix_1692_load_table_from_dataframe
branch
from
6dd6a79
to
98e568f
Compare
|
@dandhlee could you please review the changes. |
Gaurang033
force-pushed
the
feature/fix_1692_load_table_from_dataframe
branch
2 times, most recently
from
f123095
to
d06a2ac
Compare
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Gaurang033
force-pushed
the
feature/fix_1692_load_table_from_dataframe
branch
from
afe6a01
to
a731061
Compare
Gaurang033
force-pushed
the
feature/fix_1692_load_table_from_dataframe
branch
from
a731061
to
3a57815
Compare
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
| @@ -302,6 +302,20 @@ def bq_to_arrow_array(series, bq_field): | |||
| return pyarrow.Array.from_pandas(series, type=arrow_type) | |||
|
|
|||
|
|
|||
| def _check_nullability(arrow_fields, dataframe): | |||
| """Throws error if dataframe has null values and column doesn't allow nullable""" | |||
| if dataframe.index.name: | |||
There was a problem hiding this comment.
Could you please help me understand what lines 307-308 are for?
There was a problem hiding this comment.
It's hard to let you know which exact code as I am on vacation. But when dataframe with index is used, index name is transformed as airow column name. There were two way to fix it. One was to put exception for this case or the create another column with index name. I choose the second option as it's easier. Without this the dataframe unit test case where they use index names will fail.
There was a problem hiding this comment.
Thank you, hope you are having a good time in vacation! I played with dataframe's index a little bit, and I think there are several corner cases (which are likely non-comprehensive) that we need to cover:
- Index doesn't have a name, does it still get converted into arrow?
- Multiple index
- Index with the same name as columns, which is possible with dataframes
- Index columns have the same names (possible too)
- multiindex
There was a problem hiding this comment.
@Gaurang033 Thanks for offering up this PR.
@Linchin I appreciate this summary of additional edge cases that may not be covered by this solution.
I too worry about the edge cases, but more importantly, I worry about spending too much time and energy trying to create a work around for what we all agree is a problem in pyarrow. This feels like it creates greater complexity in our code, increased fragility, and a higher maintenance burden in the long run. Am I missing something?
There was a problem hiding this comment.
I am also uncertain if we should add logic in our repo to correct an issue with pyarrow. I have been thinking about this PR as more of a temporary patchwork that maybe reverted later, but for now does help our customers. However if the logic covering the corner cases get too convoluted with the behaviors of pyarrow, I agree that perhaps it's a better idea to open an issue with pyarrow instead.
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Let's just let the server-side determine if we aren't matching the correct schema. I propose #1735 instead. |
Fixes #1692