Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support julian day timestamp value conversion to datetime.datetime #1948 #1953

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erenkeskus
Copy link

I have added float casting as discussed in the issue to be able to support from julian day format.
Fixes #1948 馃

@erenkeskus erenkeskus requested review from a team as code owners June 13, 2024 09:32
Copy link

google-cla bot commented Jun 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

conventional-commit-lint-gcf bot commented Jun 13, 2024

馃 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 13, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 13, 2024
@erenkeskus erenkeskus force-pushed the support-julian-day-timestamp branch from f1cd2d5 to d78c353 Compare June 13, 2024 09:36
@erenkeskus erenkeskus force-pushed the support-julian-day-timestamp branch from d78c353 to 48e1423 Compare June 13, 2024 11:06
@Linchin Linchin assigned Linchin and unassigned alvarowolfx Jun 13, 2024
@Linchin
Copy link
Contributor

Linchin commented Jun 13, 2024

Cheers! Could you

  • sign the CLA that's linked in this comment, so we can legally merge your code
  • Add a unit test here, you can use adjacent methods as a reference

Thanks for your help :)

@chalmerlowe chalmerlowe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 14, 2024
@chalmerlowe
Copy link
Contributor

@erenkeskus @Linchin

Before we move forward with this, I have a number of questions. See Issue #1948 associated with this PR.

I added the Do Not Merge tag to prevent merging this until we ensure that we are on the same page.

Please discuss in the Issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support julian day timestamp value conversion to datetime.datetime
4 participants