Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require samples checks #409

Merged
merged 3 commits into from Dec 4, 2020
Merged

Conversation

busunkim96
Copy link
Contributor

Make samples kokoro sessions required

@busunkim96 busunkim96 requested review from a team and shollyman December 1, 2020 23:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2020
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Dec 1, 2020
@busunkim96
Copy link
Contributor Author

@tswast Are there any other sessions (snippets, system?) that should be marked required?

@tswast
Copy link
Contributor

tswast commented Dec 2, 2020

Snippets also get included in cloud.google.com docs, so makes sense to treat them the same as samples.

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 985a8cf into master Dec 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2020
@tswast tswast deleted the require-samples-checks branch July 27, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants