ci: skip docfx in main 'Kokoro' presubmit #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tswast
reviewed
Dec 8, 2020
.kokoro/build.sh
Outdated
| @@ -41,5 +41,6 @@ python3.6 -m nox --version | |||
| if [[ -n "${NOX_SESSION:-}" ]]; then | |||
| python3.6 -m nox -s "${NOX_SESSION:-}" | |||
| else | |||
| python3.6 -m nox | |||
| # docfx session runs in the 'docs-presubmit' presubmit | |||
| python3.6 -m nox -k "not docfx" | |||
There was a problem hiding this comment.
I'm curious if we should be modifying the noxfile instead? I recall there's a way to mark certain sessions as "default"
There was a problem hiding this comment.
Looks like there is! I modified the noxfile.py. PTAL
tmatsuo
approved these changes
Dec 8, 2020
tswast
approved these changes
Dec 8, 2020
|
@tmatsuo I'm having trouble figuring out what's happening with trampoline. Could you take a look? https://source.cloud.google.com/results/invocations/2451449f-1926-423b-b139-5c318c6a2e30/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery%2Fdocs%2Fdocs-presubmit/log |
|
Maybe you can modify build.sh as follows: |
tmatsuo
approved these changes
Dec 8, 2020
1 task
mamo3gr
pushed a commit
to mamo3gr/python-bigquery
that referenced
this pull request
Dec 2, 2022
* ci: skip docfx in main 'Kokoro' presubmit * fix: specify default sessions in noxfile * add conditional for cd to project root
mamo3gr
pushed a commit
to mamo3gr/python-bigquery
that referenced
this pull request
Dec 2, 2022
* ci: skip docfx in main 'Kokoro' presubmit * fix: specify default sessions in noxfile * add conditional for cd to project root
chalmerlowe
pushed a commit
that referenced
this pull request
Dec 14, 2022
* ci: skip docfx in main 'Kokoro' presubmit (#423) * ci: skip docfx in main 'Kokoro' presubmit * fix: specify default sessions in noxfile * add conditional for cd to project root * ci: use python3 instead of python3.6 in build.sh (#425) * ci: skip docfx in main 'Kokoro' presubmit * fix: specify default sessions in noxfile * fix: use python3 instead of 3.6 * fix: add NOX_SESSION to pass down envvars * fix: remove quotes arround sessions Co-authored-by: Tim Swast <swast@google.com> * fix: fix invalid version specification of pyarrow Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Tim Swast <swast@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docfxbuild is failing in continuous (reasons are unclear as we can't seem to reproduce the error locally). logThis PR makes the following changes:
docfxsession in the mainKokoropresubmit by not listing it in the default sessions listNOX_SESSIONenv var to rundocsanddocfxindocs-presubmit(needs an internal config change in 346339439)After this is approved I will open a PR in synthtool to make the changes permanent.