Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BIGNUMERIC support #527

Merged
merged 9 commits into from Feb 23, 2021
Merged

feat: add BIGNUMERIC support #527

merged 9 commits into from Feb 23, 2021

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Feb 18, 2021

Closes #367.

This is a continuation of #447 that adds extra tests and a few final touches.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from as a code owner Feb 18, 2021
@plamut plamut requested review from shollyman and removed request for Feb 18, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Feb 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Loading

@plamut
Copy link
Contributor Author

@plamut plamut commented Feb 18, 2021

@HemangChothani If you see this, can you please confirm to the bot that you consent using your commits? (this PR builds on top of your work)

Thanks!

Loading

@google-cla
Copy link

@google-cla google-cla bot commented Feb 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Loading

@plamut
Copy link
Contributor Author

@plamut plamut commented Feb 18, 2021

Tests will have to be refactored to not assume pyarrow>=3.0.0 is available (they fail when they are run with pyarrow==1.0.0) - the BIGNUMERIC fixtures and assertions need to be moved out and skipped conditionally.

Loading

Copy link
Contributor

@tswast tswast left a comment

Looking good! One suggestion regarding the version comparison. We also will need some skipifs. Might be able to do those based on the pattern we have in google-auth, with a private constant that indicates if the BIGNUMERIC feature is available.

Loading

google/cloud/bigquery/_pandas_helpers.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/_pandas_helpers.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/dbapi/_helpers.py Show resolved Hide resolved
Loading
@google-cla
Copy link

@google-cla google-cla bot commented Feb 19, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Loading

@plamut plamut requested a review from tswast Feb 19, 2021
tswast
tswast approved these changes Feb 22, 2021
Copy link
Contributor

@tswast tswast left a comment

One question, but otherwise looks good

Loading

setup.py Show resolved Hide resolved
Loading
@plamut
Copy link
Contributor Author

@plamut plamut commented Feb 23, 2021

@shollyman Can you please take a look at the CLA? The PR is a continuation of #447 which was opened by an existing maintainer, but I do see that the CLA check has failed there even though the PR was submitted before the before the new year.

(to date the original author has not yet responded here)

Loading

@tswast
Copy link
Contributor

@tswast tswast commented Feb 23, 2021

"CLAs are signed, but unable to verify author consent"

Since these commits were pulled from #447, I'm going to call that author consent and mark the label as true.

Loading

@tswast tswast added cla: yes and removed cla: no labels Feb 23, 2021
@tswast tswast merged commit cc3394f into googleapis:master Feb 23, 2021
10 of 11 checks passed
Loading
@plamut plamut deleted the iss-367 branch Feb 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 25, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.10.0](https://www.github.com/googleapis/python-bigquery/compare/v2.9.0...v2.10.0) (2021-02-25)


### Features

* add BIGNUMERIC support ([#527](https://www.github.com/googleapis/python-bigquery/issues/527)) ([cc3394f](https://www.github.com/googleapis/python-bigquery/commit/cc3394f80934419eb00c2029bb81c92a696e7d88))


### Bug Fixes

* error using empty array of structs parameter ([#474](https://www.github.com/googleapis/python-bigquery/issues/474)) ([c1d15f4](https://www.github.com/googleapis/python-bigquery/commit/c1d15f4e5da4b7e10c00afffd59a5c7f3ded027a))
* QueryJob.exception() *returns* the errors, not raises them ([#467](https://www.github.com/googleapis/python-bigquery/issues/467)) ([d763279](https://www.github.com/googleapis/python-bigquery/commit/d7632799769248b09a8558ba18f5025ebdd9675a))


### Documentation

* **bigquery:** Add alternative approach to setting credentials ([#517](https://www.github.com/googleapis/python-bigquery/issues/517)) ([60fbf28](https://www.github.com/googleapis/python-bigquery/commit/60fbf287b0d34d5db2e61cce7a5b42735ed43d0e))
* explain retry behavior for DONE jobs ([#532](https://www.github.com/googleapis/python-bigquery/issues/532)) ([696c443](https://www.github.com/googleapis/python-bigquery/commit/696c443f0a6740be0767e12b706a7771bc1460c3))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants