Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve cell magic error message on missing query #58

Merged
merged 5 commits into from Mar 26, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Mar 10, 2020

Fixes #57.

This PR fixes the Jupyter cell magic error message if query is missing. The steps to reproduce/verify the fix are in the issue description.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from shollyman Mar 10, 2020
google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
Loading
@plamut plamut merged commit 6182cf4 into googleapis:master Mar 26, 2020
3 checks passed
Loading
@plamut plamut deleted the iss-57 branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants