Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: include details of inherited class members #64

Merged
merged 3 commits into from Mar 26, 2020
Merged

docs: include details of inherited class members #64

merged 3 commits into from Mar 26, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Mar 23, 2020

Fixes #5.

This PR fixes the docs for inherited class members, their details are no longer omitted. To test, generate the docs locally and verify that e.g. LoadJob.result() details are now actually present.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: docs Improvement to the documentation for an API. label Mar 23, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2020
HemangChothani
HemangChothani approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@HemangChothani HemangChothani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@plamut
Copy link
Contributor Author

plamut commented Mar 23, 2020

FWIW, the failed test has nothing to do with the changes here, the issue is tracked here.

@plamut plamut added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@plamut plamut merged commit 9ada7a5 into googleapis:master Mar 26, 2020
@plamut plamut deleted the iss-5 branch March 26, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HemangChothani HemangChothani HemangChothani approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery google.cloud.bigquery.job.LoadJob methods return types documentation
4 participants
@plamut @HemangChothani @googlebot @yoshi-kokoro