Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LoadJobConfig.projection_fields to select DATASTORE_BACKUP fields #736

Merged
merged 5 commits into from Jul 15, 2021

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Jul 2, 2021

For https://issuetracker.google.com/191814927

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@tswast tswast requested review from as code owners Jul 2, 2021
@tswast tswast requested review from loferris and removed request for Jul 2, 2021
@google-cla google-cla bot added the cla: yes label Jul 2, 2021
Copy link
Contributor

@plamut plamut left a comment

Looks good, I just have two remarks/questions.

Loading

google/cloud/bigquery/job/load.py Show resolved Hide resolved
Loading
google/cloud/bigquery/job/load.py Outdated Show resolved Hide resolved
Loading
@tswast tswast requested a review from plamut Jul 9, 2021
Copy link
Contributor

@plamut plamut left a comment

We should annotate the setter, too. And resolve a merge conflict now that a few other PRs have been merged.

Edit: Resolved it myself, it was trivial (merging the typing imports).

Loading

google/cloud/bigquery/job/load.py Show resolved Hide resolved
Loading
@tswast tswast requested a review from plamut Jul 14, 2021
@tswast tswast changed the title feat: add LoadJobConfig.projection_fields to select DATASTORE_BACKUP fields feat: add LoadJobConfig.projection_fields to select DATASTORE_BACKUP fields Jul 14, 2021
plamut
plamut approved these changes Jul 15, 2021
@plamut plamut merged commit c45a738 into googleapis:master Jul 15, 2021
12 checks passed
Loading
@tswast tswast deleted the b191814927-projection_fields branch Jul 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 16, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 19, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.22.0](https://www.github.com/googleapis/python-bigquery/compare/v2.21.0...v2.22.0) (2021-07-19)


### Features

* add `LoadJobConfig.projection_fields` to select DATASTORE_BACKUP fields ([#736](https://www.github.com/googleapis/python-bigquery/issues/736)) ([c45a738](https://www.github.com/googleapis/python-bigquery/commit/c45a7380871af3dfbd3c45524cb606c60e1a01d1))
* add standard sql table type, update scalar type enums ([#777](https://www.github.com/googleapis/python-bigquery/issues/777)) ([b8b5433](https://www.github.com/googleapis/python-bigquery/commit/b8b5433898ec881f8da1303614780a660d94733a))
* add support for more detailed DML stats ([#758](https://www.github.com/googleapis/python-bigquery/issues/758)) ([36fe86f](https://www.github.com/googleapis/python-bigquery/commit/36fe86f41c1a8f46167284f752a6d6bbf886a04b))
* add support for user defined Table View Functions ([#724](https://www.github.com/googleapis/python-bigquery/issues/724)) ([8c7b839](https://www.github.com/googleapis/python-bigquery/commit/8c7b839a6ac1491c1c3b6b0e8755f4b70ed72ee3))


### Bug Fixes

* avoid possible job already exists error ([#751](https://www.github.com/googleapis/python-bigquery/issues/751)) ([45b9308](https://www.github.com/googleapis/python-bigquery/commit/45b93089f5398740413104285cc8acfd5ebc9c08))


### Dependencies

* allow 2.x versions of `google-api-core`, `google-cloud-core`, `google-resumable-media` ([#770](https://www.github.com/googleapis/python-bigquery/issues/770)) ([87a09fa](https://www.github.com/googleapis/python-bigquery/commit/87a09fa3f2a9ab35728a1ac925f9d5f2e6616c65))


### Documentation

* add loading data from Firestore backup sample ([#737](https://www.github.com/googleapis/python-bigquery/issues/737)) ([22fd848](https://www.github.com/googleapis/python-bigquery/commit/22fd848cae4af1148040e1faa31dd15a4d674687))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants