Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default timeout #974

Merged
merged 2 commits into from Sep 21, 2021
Merged

fix: remove default timeout #974

merged 2 commits into from Sep 21, 2021

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Sep 17, 2021

Internal folks, see: go/microgenerator-retries

"Methods will not hedge by default." (emphasis mine)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #970 馃

Internal folks, see: go/microgenerator-retries "Methods will **not** hedge by default." (emphasis mine)
Copy link
Contributor

@plamut plamut left a comment

Has this been confirmed internally as the root cause for the issue the user was facing?

The code change itself looks good.

Loading

@tswast
Copy link
Contributor Author

@tswast tswast commented Sep 20, 2021

SRE and API core teams recommends not setting default timeout. Client should still be able to set timeouts in the case when an operation needs to finish within a certain time or else fail.

Loading

@tswast
Copy link
Contributor Author

@tswast tswast commented Sep 20, 2021

In the internal go/microgenerator-retries document, default timeouts + retrying on timeout error is defined as a form of hedging, which is not supposed to happen in our clients.

Loading

@plamut
Copy link
Contributor

@plamut plamut commented Sep 21, 2021

Thanks for elaborating, let's merge it then.

Loading

plamut
plamut approved these changes Sep 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1cef0d4 into main Sep 21, 2021
12 of 13 checks passed
Loading
@gcf-merge-on-green gcf-merge-on-green bot deleted the issue970-default-timeout branch Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants