Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default timeout #974

Merged
merged 2 commits into from Sep 21, 2021
Merged

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 17, 2021

Internal folks, see: go/microgenerator-retries

"Methods will not hedge by default." (emphasis mine)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #970 馃

Internal folks, see: go/microgenerator-retries "Methods will **not** hedge by default." (emphasis mine)
@tswast tswast requested a review from a team September 17, 2021 16:46
@tswast tswast requested a review from a team as a code owner September 17, 2021 16:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 17, 2021
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been confirmed internally as the root cause for the issue the user was facing?

The code change itself looks good.

@tswast
Copy link
Contributor Author

tswast commented Sep 20, 2021

SRE and API core teams recommends not setting default timeout. Client should still be able to set timeouts in the case when an operation needs to finish within a certain time or else fail.

@tswast
Copy link
Contributor Author

tswast commented Sep 20, 2021

In the internal go/microgenerator-retries document, default timeouts + retrying on timeout error is defined as a form of hedging, which is not supposed to happen in our clients.

@plamut
Copy link
Contributor

plamut commented Sep 21, 2021

Thanks for elaborating, let's merge it then.

plamut
plamut approved these changes Sep 21, 2021
@plamut plamut added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1cef0d4 into main Sep 21, 2021
12 of 13 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the issue970-default-timeout branch September 21, 2021 07:18
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python to construct CASE WHEN update SQL statement
2 participants