Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disambiguate missing policy tags from explicitly unset policy tags #983

Merged
merged 7 commits into from Sep 24, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 22, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #981
Fixes #982
Towards googleapis/python-bigquery-pandas#387
馃

@tswast tswast requested a review from a team September 22, 2021 20:24
@tswast tswast requested a review from a team as a code owner September 22, 2021 20:24
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2021
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (with one minor nit), seems like we just need to adjust the type annotation and it should be good.

google/cloud/bigquery/schema.py Outdated Show resolved Hide resolved
google/cloud/bigquery/schema.py Outdated Show resolved Hide resolved
@tswast tswast requested a review from plamut September 23, 2021 21:24
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for a typo.

Edit: Just fixed it myself.

google/cloud/bigquery/schema.py Outdated Show resolved Hide resolved
plamut
plamut approved these changes Sep 24, 2021
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f83c00a into googleapis:main Sep 24, 2021
12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2021
@tswast tswast deleted the issue981-policyTags branch September 24, 2021 15:47
judahrand pushed a commit to judahrand/python-bigquery that referenced this pull request Sep 27, 2021
鈥s (googleapis#983)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes googleapis#981 
Fixes googleapis#982
Towards googleapis/python-bigquery-pandas#387
馃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
2 participants