Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disambiguate missing policy tags from explicitly unset policy tags #983

Merged
merged 7 commits into from Sep 24, 2021

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Sep 22, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #981
Fixes #982
Towards googleapis/python-bigquery-pandas#387
馃

Copy link
Contributor

@plamut plamut left a comment

Looks good (with one minor nit), seems like we just need to adjust the type annotation and it should be good.

Loading

google/cloud/bigquery/schema.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/schema.py Outdated Show resolved Hide resolved
Loading
@tswast tswast requested a review from plamut Sep 23, 2021
Copy link
Contributor

@plamut plamut left a comment

Looks good, except for a typo.

Edit: Just fixed it myself.

Loading

google/cloud/bigquery/schema.py Outdated Show resolved Hide resolved
Loading
plamut
plamut approved these changes Sep 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f83c00a into googleapis:main Sep 24, 2021
12 checks passed
Loading
@tswast tswast deleted the issue981-policyTags branch Sep 24, 2021
judahrand added a commit to judahrand/python-bigquery that referenced this issue Sep 27, 2021
鈥s (googleapis#983)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes googleapis#981 
Fixes googleapis#982
Towards googleapis/python-bigquery-pandas#387
馃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants