Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent sending full table scan when retrying #554

Merged
merged 4 commits into from
Apr 7, 2022
Merged

fix: Prevent sending full table scan when retrying #554

merged 4 commits into from
Apr 7, 2022

Commits on Apr 4, 2022

  1. fix: Prevent sending full table scan when retrying 

    Update the retry logic. Don't send empty row_key and empty row_ranges
if the original message didn't ask for those.

Closes internal issue 214449800
    @Mariatta
    Mariatta committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    5253d92 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Create InvalidRetryRequest exception. 

    Raise InvalidRetryRequest instead of StopIteration
Catch the InvalidRetryRequest
Handle stop the retry request if row_limit has been reached.
    @Mariatta
    Mariatta committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ceaf92d View commit details
    Browse the repository at this point in the history

  2. Improve test coverage

    @Mariatta
    Mariatta committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    9e311d3 View commit details
    Browse the repository at this point in the history

  3. Improve test coverage

    @Mariatta
    Mariatta committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    8e7b300 View commit details
    Browse the repository at this point in the history