Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure module paths #816

Merged
merged 220 commits into from Jun 28, 2023

Conversation

daniel-sanche
Copy link
Contributor

This PR moves the existing client back into place in google.cloud.bigtable, allowing the addition of the new client to be a non-breaking change. The new client is now accessed at google.cloud.bigtable.data, to avoid name collisions between similar model classes.

(Fixes #811)


As part of this move, async classes have been moved into google.cloud.bigtable.data._async subdirectory:

  • client.py
  • _mutate_rows.py
  • mutations_batcher.py
  • _read_rows.py

This resulted in a couple classes being repositioned to keep async classes fully separate from sync helper classes:

  • _StateMachine moved from _read_rows to _read_rows_statemachine
  • _MutateRowsIncomplete error moved from _mutate_rows to exceptions
  • ReadRowsIterator moved from iterators to _read_rows.

Publically-initializable async classes BigtableDataClientAsync and TableAsync are also exposed in google.cloud.bigtable.data.__init__.py, so end-users will not need to import anything from google.cloud.bigtable.data._async directly


This PR also pins the dependency for python-api-core to 2.12.0.dev0, which has support for retryable streams. Previously, users would need to install the python-api-core submodule manually to use the library, but now it should be self-contained.

2.12.0.dev0 is a pre-release developer build on pypi, so we will need to update this to the official 2.12.0 when it is ready

(Fixes #805)


Also merged the latest main back into the v3 branch, so updates to the main branch will be present in the files changed view

gcf-owl-bot bot and others added 30 commits March 16, 2023 08:01
…gleapis#750)

Source-Link: googleapis/synthtool@92006bb
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2ab4b0a0ae2907e812c209198a74e0898afcb04
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@daniel-sanche daniel-sanche requested review from a team as code owners June 26, 2023 19:18
@daniel-sanche daniel-sanche requested review from dandhlee and removed request for a team June 26, 2023 19:18
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jun 26, 2023
@snippet-bot
Copy link

snippet-bot bot commented Jun 26, 2023

Here is the summary of changes.

You are about to add 104 region tags.
You are about to delete 102 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@daniel-sanche
Copy link
Contributor Author

daniel-sanche commented Jun 26, 2023

It looks like the failing docs tests are something upstream affecting all python libraries, not related to this change:
#818

@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 27, 2023
@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2023
@daniel-sanche daniel-sanche merged commit eedde1e into googleapis:v3 Jun 28, 2023
5 of 7 checks passed
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2023
daniel-sanche added a commit that referenced this pull request Feb 5, 2024
* feat: add new v3.0.0 API skeleton (#745)

* feat: improve rows filters (#751)

* feat: read rows query model class (#752)

* feat: implement row and cell model classes (#753)

* feat: add pooled grpc transport (#748)

* feat: implement read_rows (#762)

* feat: implement mutate rows (#769)

* feat: literal value filter (#767)

* feat: row_exists and read_row (#778)

* feat: read_modify_write and check_and_mutate_row (#780)

* feat: sharded read rows (#766)

* feat: ping and warm with metadata (#810)

* feat: mutate rows batching (#770)

* chore: restructure module paths (#816)

* feat: improve timeout structure (#819)

* fix: api errors apply to all bulk mutations

* chore: reduce public api surface (#820)

* feat: improve error group tracebacks on < py11 (#825)

* feat: optimize read_rows (#852)

* chore: add user agent suffix (#842)

* feat: optimize retries (#854)

* feat: add test proxy (#836)

* chore(tests): add conformance tests to CI for v3 (#870)

* chore(tests): turn off fast fail for conformance tets (#882)

* feat: add TABLE_DEFAULTS enum for table method arguments (#880)

* fix: pass None for retry in gapic calls (#881)

* feat: replace internal dictionaries with protos in gapic calls (#875)

* chore: optimize gapic calls (#863)

* feat: expose retryable error codes to users (#879)

* chore: update api_core submodule (#897)

* chore: merge main into experimental_v3 (#900)

* chore: pin conformance tests to v0.0.2 (#903)

* fix: bulk mutation eventual success (#909)

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants