This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
chore(docs): Updating firewall samples. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: compute
Applying suggested changes. Closes #133
m-strzelczyk
force-pushed
the
sample-firewall
branch
from
fd5a4d1
to
bd2947b
Compare
parthea
approved these changes
Nov 4, 2021
crwilcox
approved these changes
Nov 4, 2021
| @@ -164,11 +166,11 @@ def delete_firewall_rule(project_id: str, firewall_rule_name: str): | |||
| create_firewall_rule(default_project_id, rule_name) | |||
| try: | |||
| print("Rule created:") | |||
| print_firewall_rule(default_project_id, rule_name) | |||
| print(get_firewall_rule(default_project_id, rule_name)) | |||
There was a problem hiding this comment.
Do we publish get_firewall_rule? It seems we don't, but we also didn't publish the print method then, so not a regression.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying suggested changes.
Closes #133
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #133 馃