This repository was archived by the owner on Sep 5, 2023. It is now read-only.
docs(samples): add samples from docs & reorganize all samples for testing#78
Merged
steffnay merged 34 commits intogoogleapis:masterfrom Aug 11, 2021
Merged
docs(samples): add samples from docs & reorganize all samples for testing#78steffnay merged 34 commits intogoogleapis:masterfrom
steffnay merged 34 commits intogoogleapis:masterfrom
Conversation
product-auto-label
bot
added
api: datacatalog
google-cla
bot
added
the
cla: yes
|
Here is the summary of changes. You are about to add 18 region tags.
You are about to delete 7 region tags.
This comment is generated by snippet-bot.
|
tswast
reviewed
Dec 1, 2020
steffnay
changed the title
tmatsuo
reviewed
Dec 7, 2020
tmatsuo
reviewed
Dec 9, 2020
tmatsuo
reviewed
Dec 9, 2020
steffnay
added
the
kokoro:force-run
Contributor
|
@steffnay snippet-bot thinks this PR will delete a region tag which is currently used. This means it will break devsite. Can you try to fix it? Let me know if it's a false positive. |
Contributor
Author
|
@tmatsuo I replaced the deleted tags. It now appears the bot doesn't recognize them as a valid prefix since they were created prior to that standard, I believe. |
Contributor
|
@steffnay It seems like the region tag prefix for Data Catalog is
|
shollyman
reviewed
Jul 27, 2021
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
The samples themselves look good, mostly my comments are my thinking about developer friction because this API has so many implicit dependencies between resources.
My other meta-comment is about the v1beta1 samples as a whole: can we simply remove them in favor of the GA endpoint?
Contributor
Author
|
@shollyman I'd like to remove the v1beta1 samples, but I was thinking I will wait to do that until the documentation on c.g.c is updated. |
shollyman
reviewed
Aug 9, 2021
shollyman
approved these changes
Aug 9, 2021
leahecole
suggested changes
Aug 10, 2021
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
I added a couple of lil nits to the requirements and also wanted to check - these noxfiles aren't modified at all, correct? (if they are, your changes will be overwritten by owlbot at some point and you should add a noxfile_config to signal what's different from base noxfile)
leahecole
approved these changes
Aug 10, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [3.4.1](https://www.github.com/googleapis/python-datacatalog/compare/v3.4.0...v3.4.1) (2021-09-01) ### Bug Fixes * make datacatalog == datacatalog_v1 ([#206](https://www.github.com/googleapis/python-datacatalog/issues/206)) ([aefe892](https://www.github.com/googleapis/python-datacatalog/commit/aefe892ab2cdb37b5f58faecd45758ea685c74ec)) ### Documentation * **samples:** add samples from docs & reorganize all samples for testing ([#78](https://www.github.com/googleapis/python-datacatalog/issues/78)) ([d34aca0](https://www.github.com/googleapis/python-datacatalog/commit/d34aca05a87aa75ad982612f57fe987a005f7896)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds samples from cloud.google.com documentation.
Updates samples.
Adds tests.
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
🦕