fix!: remove types QueryMode, QueryPlan, ResultSetStats #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
the
api: datastore
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: m
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
added
the
do not merge
parthea
requested changes
Jan 25, 2024
There was a problem hiding this comment.
We also need to delete https://github.com/googleapis/python-datastore/blob/main/google/cloud/datastore_v1/types/query_profile.py which was deleted in googleapis/googleapis@4a6230d
|
We need to either delete |
|
Maybe reverting #512, but either option works for me. Let me know if you need me to do anything for this |
|
Owl bot is regenerating pull request 517... |
fix!: remove QueryMode field from RunQueryRequest fix!: remove ResultSetStats field from RunQueryResponse fix!: remove QueryMode field from RunAggregationQueryRequest fix!: remove ResultSetStats field from RunAggregationQueryResponse PiperOrigin-RevId: 601486345 Source-Link: googleapis/googleapis@4a6230d Source-Link: googleapis/googleapis-gen@db652ee Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGI2NTJlZTgzZWQ2NTgxNmVjNmQ5MTBkOTY1NDU4ZDY4NGEzMWM3MyJ9
gcf-owl-bot
bot
force-pushed
the
owl-bot-copy
branch
from
da55f44
to
b4b0ee6
Compare
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: xl
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: u
gcf-owl-bot
bot
removed
the
owlbot:run
|
Owlbot closed this PR because it would result in an empty changeset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix!: remove QueryMode field from RunQueryRequest
fix!: remove ResultSetStats field from RunQueryResponse
fix!: remove QueryMode field from RunAggregationQueryRequest
fix!: remove ResultSetStats field from RunAggregationQueryResponse
PiperOrigin-RevId: 601486345
Source-Link: googleapis/googleapis@4a6230d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/db652ee83ed65816ec6d910d965458d684a31c73
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGI2NTJlZTgzZWQ2NTgxNmVjNmQ5MTBkOTY1NDU4ZDY4NGEzMWM3MyJ9