Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix unit test broken by google-cloud-core release #54

Merged
merged 1 commit into from Aug 5, 2020
Merged

tests: fix unit test broken by google-cloud-core release #54

merged 1 commit into from Aug 5, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 5, 2020

Closes #53

@tseaver tseaver added the testing label Aug 5, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@tseaver tseaver mentioned this pull request Aug 5, 2020
Closed
@tseaver tseaver changed the title testing: fix unit test borked by google-cloud-core release tests: fix unit test broken by google-cloud-core release Aug 5, 2020
@tseaver tseaver merged commit 79311a1 into master Aug 5, 2020
@tseaver tseaver deleted the 53-fix-test-borked-by-g-c-core-release branch August 5, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@chrisrossi chrisrossi Awaiting requested review from chrisrossi

@cguardia cguardia Awaiting requested review from cguardia

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'TestClient.test_constructor_w_implicit_inputs' unit test failure
2 participants
@tseaver @tmatsuo