Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smooth over system test bumps #66

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

chrisrossi
Copy link
Contributor

Adds back some missing documentation to CONTRIBUTING.rst that covers
creating indexes and populating test data for system tests.

Also increases the number of timestamp_key entities created by
populate_datastore.py to 10000, so that system tests can pass.

Adds back some missing documentation to `CONTRIBUTING.rst` that covers
creating indexes and populating test data for system tests.

Also increases the number of `timestamp_key` entities created by
`populate_datastore.py` to 10000, so that system tests can pass.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2020
@chrisrossi
Copy link
Contributor Author

If there's a more elegant way to do this, I'm open to suggestions.

I didn't check in changes to synth.metadata after running synthtool. I'm not entirely sure on the policy for that.

@tseaver
Copy link
Contributor

tseaver commented Aug 11, 2020

@chrisrossi If you don't check them in, then the bot will submit a PR tomorrow. No biggie. Usually, though, I check in synth.metadata if synthtool produced any other changes (like the ones in CONTRIBUTING.md).

@chrisrossi chrisrossi merged commit 8bb17ea into googleapis:master Aug 12, 2020
@chrisrossi chrisrossi deleted the fix-system-tests branch August 12, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants