Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add blocks to PageWrapper #107

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

sharmanirudh
Copy link
Contributor

@sharmanirudh sharmanirudh commented Apr 17, 2023

Add feature to get the blocks present in the Document AI JSON response as a Python list of documentai.Document.Page.Block objects, similar to the way to get the paragraphs and lines.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass - I don't know how to configure these. Any help would be really appreciated.
  • Code coverage does not decrease (if any source code was changed) - I don't know how to configure and run these. Any help would be really appreciated.
  • Appropriate docs were updated (if necessary)

Fixes #106 馃

Add feature to get the blocks present in the Document AI JSON response
as a Python list of documentai.Document.Page.Block objects, similar to
the way to get the paragraphs and lines.
@google-cla
Copy link

google-cla bot commented Apr 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 17, 2023
@holtskinner
Copy link
Member

Thanks for the contribution!

Please write Unit Tests for your new function

They should go in https://github.com/googleapis/python-documentai-toolbox/blob/main/tests/unit/test_page.py

And make sure that the other unit tests still pass.

Add Unit Tests for #d9e6ada
@sharmanirudh
Copy link
Contributor Author

Thanks for the contribution!

Please write Unit Tests for your new function

They should go in https://github.com/googleapis/python-documentai-toolbox/blob/main/tests/unit/test_page.py

And make sure that the other unit tests still pass.

Thanks for your prompt help, I've added the Unit Tests.

@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2023
@holtskinner holtskinner merged commit df7dfe7 into googleapis:main Apr 17, 2023
@sharmanirudh
Copy link
Contributor Author

Thanks @holtskinner for your prompt help 馃檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to get the blocks in PageWrapper
3 participants