Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add DocumentWrapper, EntityWrapper, PageWrapper #3

Merged
merged 19 commits into from Sep 20, 2022
Merged

Chore: Add DocumentWrapper, EntityWrapper, PageWrapper #3

merged 19 commits into from Sep 20, 2022

Conversation

galz10
Copy link
Collaborator

@galz10 galz10 commented Sep 8, 2022 •
edited

BEGIN_COMMIT_OVERRIDE
feat: Initial Release
END_COMMIT_OVERRIDE

@galz10 galz10 requested a review from a team as a code owner September 8, 2022 17:24
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

dizcology
dizcology requested changes Sep 8, 2022
View reviewed changes
google/cloud/documentai_toolbox/__init__.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/types/__init__.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/services/__init__.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/services/document_wrapper_service.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/services/document_wrapper_service.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/types/document_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/types/entity_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/types/entity_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/types/entity_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/types/entity_wrapper.py Outdated Show resolved Hide resolved
dizcology
dizcology requested changes Sep 12, 2022
View reviewed changes
docs/documentai_toolbox/services.rst Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/types/__init__.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/entity_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/entity_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/page_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/page_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/page_wrapper.py Outdated Show resolved Hide resolved
Base automatically changed from prototype_v0 to main September 14, 2022 20:24
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 14, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Sep 16, 2022
dizcology
dizcology requested changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@dizcology dizcology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a few last comments.

google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/page_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/page_wrapper.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated Show resolved Hide resolved
tests/unit/test_document_wrapper.py Show resolved Hide resolved
tests/unit/test_document_wrapper.py Outdated Show resolved Hide resolved
@galz10 galz10 requested a review from a team as a code owner September 19, 2022 22:27
@galz10 galz10 requested a review from engelke September 19, 2022 22:27
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Sep 19, 2022
@galz10 galz10 removed request for a team and engelke September 20, 2022 17:49
@galz10 galz10 merged commit e360dce into main Sep 20, 2022
@galz10 galz10 deleted the v0_code branch September 20, 2022 18:18
@galz10 galz10 added the release-please:force-run To run release-please label Sep 22, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@galz10 @dizcology