Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception when grpc is disabled #190

Merged
merged 5 commits into from Oct 11, 2021
Merged

fix: exception when grpc is disabled #190

merged 5 commits into from Oct 11, 2021

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Oct 8, 2021

Fixes #135

The library was crashing when grpc was disabled. Initializing logging client using keyword arguments instead of positional ones fixes this

I also added a test to prevent these issues in the future

Copy link

@losalex losalex left a comment

LGTM

Loading

minherz
minherz approved these changes Oct 9, 2021
@minherz
Copy link

@minherz minherz commented Oct 9, 2021

Question: Should we test this behavior for libraries in other languages?

Loading

@daniel-sanche
Copy link
Contributor Author

@daniel-sanche daniel-sanche commented Oct 11, 2021

Question: Should we test this behavior for libraries in other languages?

Yes, this would be a good test to add for other languages as well

Loading

@daniel-sanche daniel-sanche merged commit 929e293 into main Oct 11, 2021
11 checks passed
Loading
@daniel-sanche daniel-sanche deleted the fix-grpc branch Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants