Dedupe sync/async paths of recursive delete code #425
Labels
api: firestore
Issues related to the googleapis/python-firestore API.
type: cleanup
An internal cleanup or hygiene concern.
https://github.com/googleapis/python-firestore/pull/420/files#diff-ae4779c3bae12c581abba3732b4ed80ab155b08787b617798a06e36cb0642052R342
Currently the sync/async versions of recursive delete are pretty similar. A thought: What if the sync version managed accessing the event loop, using the async implementation, and blocking.
Perf should likely be investigated when doing this but it may be a way to avoid duplicate code throughout the two halves if the event loop doesn't add significant overhead.
The text was updated successfully, but these errors were encountered: