Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Cross Language tests for v2 #95

Closed
crwilcox opened this issue Jul 14, 2020 · 3 comments · Fixed by #205
Closed

Run Cross Language tests for v2 #95

crwilcox opened this issue Jul 14, 2020 · 3 comments · Fixed by #205
Assignees
@tseaver
Labels
api: firestore Issues related to the googleapis/python-firestore API. help wanted We'd love to have community involvement on this issue. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Milestone
v2

Comments

@crwilcox
Copy link
Contributor

tests/unit/v1/test_cross_language.py → tests/unit/v1/_test_cross_language.py

remove the leading _ and begin testing with these again. Disabled as the protos for this need to be generated with protoplus to run correctly. (see makefile)
@crwilcox crwilcox added this to the v2 milestone Jul 14, 2020
@crwilcox crwilcox added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jul 14, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Jul 14, 2020
@crwilcox crwilcox added the help wanted We'd love to have community involvement on this issue. label Sep 17, 2020
@HemangChothani
Copy link
Contributor

@crwilcox I have generated test.proto file as per mentioned in makefile, so should i open a PR https://github.com/googleapis/googleapis here with new generated test.proto file?

@crwilcox
Copy link
Contributor Author

crwilcox commented Sep 18, 2020 •
edited

@HemangChothani you modified the makefile to generate using protoplus? We need to do that and modify the cross_language test (possibly) to manage that. I don't believe this will require code to be updated at googleapis/googleapis. I think the output ends up living in this repository.

@HemangChothani
Copy link
Contributor

HemangChothani commented Sep 21, 2020 •
edited

@crwilcox No, i didn't make any changes in makefile, i had follow the steps and generate test_pb2.py file, i don't know what changes needs to be done in makefile related to protoplus, i have tried to find any related documentation, but not succeed.

@HemangChothani HemangChothani mentioned this issue Sep 22, 2020
Closed
@tseaver tseaver self-assigned this Sep 22, 2020
@tseaver tseaver mentioned this issue Sep 25, 2020
Merged
tseaver added a commit that referenced this issue Sep 25, 2020
@tseaver
tests: get cross-language conftests working on 'master'
4c13243 
Closes #95.
tseaver added a commit that referenced this issue Oct 6, 2020
@tseaver
tests: get cross-language conftests working on 'master'
15e0108 
Closes #95.
tseaver added a commit that referenced this issue Oct 7, 2020
@tseaver @crwilcox
tests: re-enable cross-language conformance tests (#205)
c3acd4a 
Leaving existing (old) conftest JSON files in place for now. in order
to  get the conftest runner working using existing semantics,
before updating the JSON files and making required changes (to use
'update_transforms', for instance) in a future PR.

Closes #95.

Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the googleapis/python-firestore API. help wanted We'd love to have community involvement on this issue. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

tests: re-enable cross-language conformance tests googleapis/python-firestore
3 participants
@tseaver @crwilcox @HemangChothani