Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

feat: asyncio system tests#132

Merged
rafilong merged 18 commits into
googleapis:v2-stagingfrom
rafilong:asyncio-system-tests
Jul 29, 2020
Merged

feat: asyncio system tests#132
rafilong merged 18 commits into
googleapis:v2-stagingfrom
rafilong:asyncio-system-tests

Conversation

@rafilong

@rafilong rafilong commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

Added system tests and removed Watch from interface. Opened issue to re-add Watch support at a later date googleapis/google-cloud-python#15398.

Additionally, made fixes to improperly mocked return types in AsyncClient.list_documents and AsyncQuery.stream.

This PR is stacked on #123.

@rafilong rafilong added this to the AsyncIO Client milestone Jul 28, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2020
Comment thread google/cloud/firestore_v1/async_collection.py
@rafilong rafilong force-pushed the asyncio-system-tests branch from d11d572 to 3cd740b Compare July 28, 2020 20:51
Comment thread google/cloud/firestore_v1/__init__.py
Comment thread google/cloud/firestore_v1/async_client.py Outdated
Comment thread google/cloud/firestore_v1/async_collection.py
Comment thread tests/unit/v1/test_async_collection.py
@rafilong rafilong requested a review from crwilcox July 28, 2020 21:38
Comment thread tests/system/test_system_async.py Outdated
Comment thread tests/system/test_system_async.py
Comment thread tests/system/test_system_async.py Outdated
@rafilong rafilong requested a review from BenWhitehead July 29, 2020 17:35
@rafilong rafilong merged commit 4256a85 into googleapis:v2-staging Jul 29, 2020
@rafilong rafilong deleted the asyncio-system-tests branch July 29, 2020 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants