Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type hints for method params #182

Merged
merged 6 commits into from Oct 9, 2020
Merged

feat: add type hints for method params #182

merged 6 commits into from Oct 9, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #140

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2020
@HemangChothani HemangChothani changed the title Firestore issue 140 feat: add type hints for method params Sep 2, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Sep 3, 2020
@tseaver
Copy link
Contributor

tseaver commented Sep 16, 2020

Blocked on #188.

@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Sep 16, 2020
@tseaver tseaver mentioned this pull request Sep 16, 2020
Closed
@tseaver tseaver removed the status: blocked Resolving the issue is dependent on other work. label Sep 24, 2020
@HemangChothani HemangChothani requested a review from a team October 8, 2020 10:26
@HemangChothani
Copy link
Contributor Author

@tseaver @crwilcox PTAL!

@crwilcox crwilcox merged commit 9b6c2f3 into googleapis:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve type hints, add types to method params
3 participants
@HemangChothani @tseaver @crwilcox