Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add imports into test_collections systest #88

Merged
merged 3 commits into from Jul 16, 2020
Merged

test: add imports into test_collections systest #88

merged 3 commits into from Jul 16, 2020

Conversation

IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented Jul 9, 2020

Closes #84

@IlyaFaer IlyaFaer added api: firestore Issues related to the googleapis/python-firestore API. type: process A process-related concern. May include testing, release, or the like. labels Jul 9, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2020
@IlyaFaer IlyaFaer requested a review from crwilcox July 9, 2020 08:48
@IlyaFaer IlyaFaer marked this pull request as ready for review July 9, 2020 08:48
@crwilcox crwilcox merged commit 4471923 into googleapis:master Jul 16, 2020
crwilcox pushed a commit to crwilcox/python-firestore that referenced this pull request Jul 16, 2020
@crwilcox
test: add imports into test_collections systest (googleapis#88)
cfe3ab5 
* test: add imports into test_collections systest

* Revert "test: add imports into test_collections systest"

This reverts commit beaefa5.

* move the test into a separate case
@crwilcox crwilcox mentioned this pull request Jul 16, 2020
Merged
@IlyaFaer IlyaFaer deleted the collection_w_import_systest branch July 16, 2020 16:29
crwilcox added a commit that referenced this pull request Jul 16, 2020
@crwilcox
test: add imports into test_collections systest (#88) (#105)
cb8606a 
* test: add imports into test_collections systest

* Revert "test: add imports into test_collections systest"

This reverts commit beaefa5.

* move the test into a separate case

Co-authored-by: Gurov Ilya <ilya.faer@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add System Test that gets collections
3 participants
@IlyaFaer @crwilcox @googlebot