Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct BackupSchedule recurrence docs that mentioned specific time of day #898

Merged
merged 2 commits into from Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -3001,7 +3001,7 @@ async def sample_delete_backup_schedule():
The request object. The request for
[FirestoreAdmin.DeleteBackupSchedules][].
name (:class:`str`):
Required. The name of backup schedule.
Required. The name of the backup schedule.

Format
``projects/{project}/databases/{database}/backupSchedules/{backup_schedule}``
Expand Down
Expand Up @@ -3470,7 +3470,7 @@ def sample_delete_backup_schedule():
The request object. The request for
[FirestoreAdmin.DeleteBackupSchedules][].
name (str):
Required. The name of backup schedule.
Required. The name of the backup schedule.

Format
``projects/{project}/databases/{database}/backupSchedules/{backup_schedule}``
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/firestore_admin_v1/types/firestore_admin.py
Expand Up @@ -329,7 +329,7 @@ class DeleteBackupScheduleRequest(proto.Message):

Attributes:
name (str):
Required. The name of backup schedule.
Required. The name of the backup schedule.

Format
``projects/{project}/databases/{database}/backupSchedules/{backup_schedule}``
Expand Down
7 changes: 3 additions & 4 deletions google/cloud/firestore_admin_v1/types/schedule.py
Expand Up @@ -72,13 +72,12 @@ class BackupSchedule(proto.Message):
to its creation time, the backup should be
deleted, e.g. keep backups for 7 days.
daily_recurrence (google.cloud.firestore_admin_v1.types.DailyRecurrence):
For a schedule that runs daily at a specified
time.
For a schedule that runs daily.

This field is a member of `oneof`_ ``recurrence``.
weekly_recurrence (google.cloud.firestore_admin_v1.types.WeeklyRecurrence):
For a schedule that runs weekly on a specific
day and time.
day.

This field is a member of `oneof`_ ``recurrence``.
"""
Expand Down Expand Up @@ -117,7 +116,7 @@ class BackupSchedule(proto.Message):


class DailyRecurrence(proto.Message):
r"""Represent a recurring schedule that runs at a specific time
r"""Represents a recurring schedule that runs at a specific time
every day.
The time zone is UTC.

Expand Down