Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Commit

Permalink
fix: Add async context manager return types (#242)
Browse files Browse the repository at this point in the history
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] committed Jul 4, 2023
1 parent 88cd87a commit 7b933e0
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 25 deletions.
2 changes: 1 addition & 1 deletion google/cloud/gkehub_v1/services/gke_hub/async_client.py
Expand Up @@ -1556,7 +1556,7 @@ async def sample_generate_connect_manifest():
# Done; return the response.
return response

async def __aenter__(self):
async def __aenter__(self) -> "GkeHubAsyncClient":
return self

async def __aexit__(self, exc_type, exc, tb):
Expand Down
Expand Up @@ -1778,7 +1778,7 @@ async def list_locations(
# Done; return the response.
return response

async def __aenter__(self):
async def __aenter__(self) -> "GkeHubMembershipServiceAsyncClient":
return self

async def __aexit__(self, exc_type, exc, tb):
Expand Down
Expand Up @@ -1758,7 +1758,7 @@ def __call__(
request_kwargs = json_format.MessageToDict(request)
transcoded_request = path_template.transcode(http_options, **request_kwargs)

body = json.loads(json.dumps(transcoded_request["body"]))
body = json.dumps(transcoded_request["body"])
uri = transcoded_request["uri"]
method = transcoded_request["method"]

Expand Down Expand Up @@ -1830,7 +1830,7 @@ def __call__(
request_kwargs = json_format.MessageToDict(request)
transcoded_request = path_template.transcode(http_options, **request_kwargs)

body = json.loads(json.dumps(transcoded_request["body"]))
body = json.dumps(transcoded_request["body"])
uri = transcoded_request["uri"]
method = transcoded_request["method"]

Expand Down Expand Up @@ -1899,7 +1899,7 @@ def __call__(
request_kwargs = json_format.MessageToDict(request)
transcoded_request = path_template.transcode(http_options, **request_kwargs)

body = json.loads(json.dumps(transcoded_request["body"]))
body = json.dumps(transcoded_request["body"])
uri = transcoded_request["uri"]
method = transcoded_request["method"]

Expand Down
Expand Up @@ -8,7 +8,7 @@
],
"language": "PYTHON",
"name": "google-cloud-gke-hub",
"version": "1.10.0"
"version": "0.1.0"
},
"snippets": [
{
Expand Down
Expand Up @@ -8,7 +8,7 @@
],
"language": "PYTHON",
"name": "google-cloud-gke-hub",
"version": "1.10.0"
"version": "0.1.0"
},
"snippets": [
{
Expand Down
18 changes: 8 additions & 10 deletions tests/unit/gapic/gkehub_v1/test_gke_hub.py
Expand Up @@ -1089,9 +1089,11 @@ async def test_list_memberships_async_pages():
RuntimeError,
)
pages = []
async for page_ in (
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
async for page_ in ( # pragma: no branch
await client.list_memberships(request={})
).pages: # pragma: no branch
).pages:
pages.append(page_)
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
assert page_.raw_page.next_page_token == token
Expand Down Expand Up @@ -1509,9 +1511,11 @@ async def test_list_features_async_pages():
RuntimeError,
)
pages = []
async for page_ in (
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
async for page_ in ( # pragma: no branch
await client.list_features(request={})
).pages: # pragma: no branch
).pages:
pages.append(page_)
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
assert page_.raw_page.next_page_token == token
Expand Down Expand Up @@ -1542,9 +1546,6 @@ def test_get_membership(request_type, transport: str = "grpc"):
description="description_value",
external_id="external_id_value",
unique_id="unique_id_value",
endpoint=membership.MembershipEndpoint(
gke_cluster=membership.GkeCluster(resource_link="resource_link_value")
),
)
response = client.get_membership(request)

Expand Down Expand Up @@ -4285,9 +4286,6 @@ def test_get_membership_rest(request_type):
description="description_value",
external_id="external_id_value",
unique_id="unique_id_value",
endpoint=membership.MembershipEndpoint(
gke_cluster=membership.GkeCluster(resource_link="resource_link_value")
),
)

# Wrap the value into a proper Response obj
Expand Down
Expand Up @@ -1184,9 +1184,11 @@ async def test_list_memberships_async_pages():
RuntimeError,
)
pages = []
async for page_ in (
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
async for page_ in ( # pragma: no branch
await client.list_memberships(request={})
).pages: # pragma: no branch
).pages:
pages.append(page_)
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
assert page_.raw_page.next_page_token == token
Expand Down Expand Up @@ -1218,9 +1220,6 @@ def test_get_membership(request_type, transport: str = "grpc"):
external_id="external_id_value",
unique_id="unique_id_value",
infrastructure_type=membership.Membership.InfrastructureType.ON_PREM,
endpoint=membership.MembershipEndpoint(
gke_cluster=membership.GkeCluster(resource_link="resource_link_value")
),
)
response = client.get_membership(request)

Expand Down Expand Up @@ -3053,9 +3052,6 @@ def test_get_membership_rest(request_type):
external_id="external_id_value",
unique_id="unique_id_value",
infrastructure_type=membership.Membership.InfrastructureType.ON_PREM,
endpoint=membership.MembershipEndpoint(
gke_cluster=membership.GkeCluster(resource_link="resource_link_value")
),
)

# Wrap the value into a proper Response obj
Expand Down

0 comments on commit 7b933e0

Please sign in to comment.