Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove noisy logs #290

Merged
merged 6 commits into from May 11, 2021
Merged

fix: remove noisy logs #290

merged 6 commits into from May 11, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented May 10, 2021

  • Adds "google.api_core.bidi" and "werkzeug" to the list of excluded logs to fix some noisyness on some environments
  • Previously, SteamHandlers were added to excluded loggers by default, so they would still log to standard output. This is leading to noisy logs on environments that send all stdout to Cloud Logging. Instead, users should expect to add handlers manually if desired

Fixes #261

@daniel-sanche daniel-sanche self-assigned this May 10, 2021
@daniel-sanche daniel-sanche requested review from as code owners May 10, 2021
@product-auto-label product-auto-label bot added the api: logging label May 10, 2021
@google-cla google-cla bot added the cla: yes label May 10, 2021
google/cloud/logging_v2/handlers/handlers.py Outdated Show resolved Hide resolved
@daniel-sanche daniel-sanche merged commit fe08351 into v2_update_2 May 11, 2021
16 checks passed
@daniel-sanche daniel-sanche deleted the remove-noise branch May 11, 2021
daniel-sanche added a commit that referenced this issue May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants