-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): remove get_default_handler call from samples/snippets/handler.py #421
Conversation
Since `client.setup_logging()` calls `self.get_default_handler(**kw)` internally, the call here is not needed.
Dangit, didn't see the conventionalcommits.org requirement in the contributing docs; can't work out how to change commit messages through Github UI so will get on the command line later to change it. |
Don't worry about changing the commits. PRs are squashed based on PR name, so as long as the name follows conventions, it'll be fine. The Cloud Build and 3.10 tests are also expected to fail now, as we're in the process of adding new tests As for the change itself, It makes sense. We may want to make a different sample showing users how to access the default_handler, but we can address that in the upcoming v3.0.0 docs update Thanks for opening this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests are passing
It looks like they only failing tests are Cloud Build (not fully implemented) and Python 3.10 (known issue, still rolling out) |
Since
client.setup_logging()
callsself.get_default_handler(**kw)
internally, I don't think the call here is needed (e.g. it's not showing the users how to do something else).Apologies, I'm currently doing this through the Github UI; I don't see how this could break tests (but that's the point of having tests) but if I need to run the tests/linter/coverage, please let me know.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #420